Changeset 1688

Timestamp:

06/23/10 12:45:32 (14 years ago)

Author:

dsimcha

Message:

save() for std.algorithm.filter, WITH proper unittests.

Files:

• trunk/docsrc/changelog.dd (modified) (1 diff)
• trunk/phobos/std/algorithm.d (modified) (1 diff)

trunk/docsrc/changelog.dd

@@ -2 +2 @@
-
-$(D_S D Change Log,
-
-
-$(VERSION 048, Jun 11, 2010, =================================================,
-
-    $(WHATSNEW
-    $(LI std.string: icmp() now works with all built-in string types.)
-    )
-    $(BUGSFIXED
+    $(L1 $(Unlisted Bug):  std.algorithm.filter not a forward range.
-    $(LI $(BUGZILLA 978): std.utf's toUTF* functions accept some invalid and reject some valid UTF)
-    $(LI $(BUGZILLA 996): Error in doc on implicit conversion between pointer and array)
-    $(LI $(BUGZILLA 2275): std.utf.toUTF16z() should return const(wchar)*)
-    $(LI $(BUGZILLA 2872): Length, opIndex for Map)
-    $(LI $(BUGZILLA 3202): std.math.pow cause dead loop)
-    $(LI $(BUGZILLA 3355): std.string.cmp works incorrectly for mixed-type and different-length strings)
-    $(LI $(BUGZILLA 3386): to!bool(string) is not implemented)
-    $(LI $(BUGZILLA 3436): std.functional.compose with only one function)
-    $(LI $(BUGZILLA 3439): std.range.Sequence.opIndex not consistent after calling popFront().)
-    $(LI $(BUGZILLA 3447): std.file uses unconventional file permissions)
-    $(LI $(BUGZILLA 3961): Error with to!(somestruct))
-    $(LI $(BUGZILLA 4109): (reopened) writeln doesn't work with empty static array)
-    $(LI $(BUGZILLA 4171): std.random.uniform does not work for a range of characters)
-    $(LI $(BUGZILLA 4327): std.container.Array.Range.~this() tries to call free(T[]))
+    $(LI $(BUGZILLA 4362): std.range.repeat and cycle do not have a .save() method
-    $(LI $(BUGZILLA 4363): std.algorithm.Until is not a forward range)
-    )
-)
-
-<div id=version>
-$(UL
-    $(NEW 048)
-    $(NEW 047)
-    $(NEW 046)
-    $(NEW 045)

trunk/phobos/std/algorithm.d

@@ -574 +574 @@
-    {
-        do
-        {
-            _input.popFront;
-        } while (!_input.empty && !pred(_input.front));
-    }
-
-    ElementType!(Range) front()
-    {
-        return _input.front;
+    }
+
+    static if(isForwardRange!Range)
+    {
+        @property typeof(this) save()
+        {
+            return typeof(this)(_input.save);
+        }
-    }
-}
-
-unittest
-{
-    int[] a = [ 3, 4 ];
-    auto r = filter!("a > 3")(a);
-    assert(equal(r, [ 4 ][]));
+    static assert(isForwardRange!(typeof(r)));
-
-    a = [ 1, 22, 3, 42, 5 ];
-    auto under10 = filter!("a < 10")(a);
-    assert(equal(under10, [1, 3, 5][]));
-
+
+
-    auto infinite = filter!"a > 2"(repeat(3));
-    static assert(isInfinite!(typeof(infinite)));
+    static assert(isForwardRange!(typeof(infinite)));
-}
-
-// move
-/**
-Moves $(D source) into $(D target) via a destructive
-copy. Specifically: $(UL $(LI If $(D hasAliasing!T) is true (see
-$(XREF traits, hasAliasing)), then the representation of $(D source)
-is bitwise copied into $(D target) and then $(D source = T.init) is
-evaluated.)  $(LI Otherwise, $(D target = source) is evaluated.)) See
-also $(XREF contracts, pointsTo).