Changeset 1559

Timestamp:

05/26/10 14:21:39 (15 years ago)

Author:

rsinfu

Message:

Reverted r1557 (and r1513 partially).

r1557 relaxed some unittests, as some platforms had accuracy problem with strtold(). But the strict unittests were requirements for D; so r1557 should be reverted.

With this change, these unittests will fail on some platforms such as OSX and Gentoo. However, the unittests SHOULD fail because using strtold() on these platforms is a 'bug' -- we should provide an accurate implementation.

Related issues:
3758: Create D impementation of to!(float, string), etc.
4200: "to!real(to!string(real.min_normal))" raises std.conv.ConvError?

Files:

• trunk/phobos/std/conv.d (modified) (3 diffs)
• trunk/phobos/std/getopt.d (modified) (1 diff)

trunk/phobos/std/conv.d

@@ -1872 +1872 @@
-    assert( f == 123e+2f );
-
-    f = to!float( "123e-2" );
-    assert( f == 123e-2f );
-    f = to!float( "123." );
-    assert( f == 123.f );
-    f = to!float( ".456" );
-    assert( f == .456f );
-
-    // min and max
-5
-5
+49
+49
-    assert(feq(cast(real)f, cast(real)float.min_normal));
-    f = to!float("3.4028e+38");
-
+2
-
-    // nan
-    f = to!float("nan");
-    assert(to!string(f) == to!string(float.nan));
-
-    bool ok = false;
-    try
-    {
-        to!float("\x00");
-    }
@@ -1921 +1921 @@
-    d = to!double( "123e-2" );
-    assert( d == 123e-2 );
-    d = to!double( "123." );
-    assert( d == 123. );
-    d = to!double( ".456" );
-    assert( d == .456 );
-    d = to!double( "1.23456E+2" );
-    assert( d == 1.23456E+2 );
-
-    // min and max
-1
-1
+08
+08
-    assert(feq(cast(real)d, cast(real)double.min_normal));
-
-
+
+
+
-
-    // nan
-    d = to!double("nan");
-    assert(to!string(d) == to!string(double.nan));
-    //assert(cast(real)d == cast(real)double.nan);
-
-    bool ok = false;
-    try
-    {
-        to!double("\x00");
@@ -1965 +1966 @@
-    assert(r == 123L);
-    r = to!real("-123");
-    assert(r == -123L);
-    r = to!real("123e2");
-    assert(feq(r, 123e2L));
-    r = to!real("123e-2");
-    assert(feq(r, 1.23L));
-    r = to!real("123.");
-    assert(r == 123L);
-    r = to!real(".456");
-feq(r, .456L)
+r == .456L
-
-    r = to!real("1.23456e+2");
-    assert(feq(r,  1.23456e+2L));
-    r = to!real(to!string(real.max / 2L));
-    assert(to!string(r) == to!string(real.max / 2L));
-
-    // min and max
-
-
-
-
-
-
-
+
+
+
+
-
-    // nan
-    r = to!real("nan");
-    assert(to!string(r) == to!string(real.nan));
-    //assert(r == real.nan);
-
-    r = to!real(to!string(real.nan));
-    assert(to!string(r) == to!string(real.nan));
-    //assert(r == real.nan);
-

trunk/phobos/std/getopt.d

@@ -576 +576 @@
-    getopt(args, "output", &outputFiles);
-    assert(outputFiles.length == 2
-           && outputFiles[0] == "myfile.txt" && outputFiles[0] == "myfile.txt");
-
-    args = (["program.name", "--tune=alpha=0.5",
-             "--tune", "beta=0.6"]).dup;
-    double[string] tuningParms;
-    getopt(args, "tune", &tuningParms);
-    assert(args.length == 1);
-    assert(tuningParms.length == 2);
-0.4999 < tuningParms["alpha"] && tuningParms["alpha"] < 0.5001
-0.5999 < tuningParms["beta"] && tuningParms["beta"] < 0.6001
+tuningParms["alpha"] == 0.5
+tuningParms["beta"] == 0.6
-
-    uint verbosityLevel = 1;
-    void myHandler(string option)
-    {
-        if (option == "quiet")
-        {
-            verbosityLevel = 0;
-        }
-        else
-        {