Changeset 1555

Timestamp:

05/26/10 05:59:30 (15 years ago)

Author:

rsinfu

Message:

Fixed bugzilla 3786: bug in std.string.removechars.
Thanks to Igor Lesik for the fix!

Files:

• trunk/docsrc/changelog.dd (modified) (1 diff)
• trunk/phobos/std/string.d (modified) (1 diff)

trunk/docsrc/changelog.dd

@@ -10 +10 @@
-    $(LI std.traits: Added templates to get compile-time information about functions.)
-    $(LI std.typecons: Added tie and AutoImplement.)
-    )
-    $(BUGSFIXED
-    $(LI $(BUGZILLA 2738): Rebindable should work for interfaces.)
-    $(LI $(BUGZILLA 2835): std.socket.TcpSocket doesn't actually connect)
-    $(LI $(BUGZILLA 3088): std.xml.check() fails on xml comments)
-    $(LI $(BUGZILLA 3200): std.xml doesn't follow spec for Tag.text)
-    $(LI $(BUGZILLA 3465): isIdeographic can be wrong in std.xml)
-    $(LI $(BUGZILLA 3653): Problem sorting array of Rebindable)
+    $(LI $(BUGZILLA 3786): bug in std.string.removechars)
-    $(LI $(BUGZILLA 3873): std.range.repeat should have popBack defined)
-    $(LI $(BUGZILLA 3880): std.regex functions with const/immutable Regex object)
-    $(LI $(BUGZILLA 4109): writeln doesn't work with empty static array)
-    $(LI $(BUGZILLA 4202): Changset 1517 doesn't compile)
-    $(LI $(BUGZILLA 4228): std.array.replace contains 2 bugs)
-    $(LI $(BUGZILLA 4219): hasAliasing does not care about immutable)
-    )
-)
-
-<div id=version>

trunk/phobos/std/string.d

@@ -2806 +2806 @@
-}
-
-
-/********************************************
- * Return string that is s with all characters removed that match pattern.
- */
-
-string removechars(string s, in string pattern)
-{
-    char[] r;
-
-
-
+
+
-    foreach (size_t i, dchar c; s)
-    {
-
-
-
-
+
+
+
+
+
+
-        }
-        if (changed)
-        {
-            std.utf.encode(r, c);
-        }
-    }
-
-
-
+
+
-unittest
-{
-    debug(string) printf("std.string.removechars.unittest\n");
-
-    string r;
-
-    r = removechars("abc", "a-c");
-    assert(r.length == 0);
-    r = removechars("hello world", "or");
-    assert(r == "hell wld");
-    r = removechars("hello world", "d");
-    assert(r == "hello worl");
+    r = removechars("hah", "h");
+    assert(r == "a");
-}
-
-
-/***************************************************
- * Return string where sequences of a character in s[] from pattern[]
- * are replaced with a single instance of that character.
- * If pattern is null, it defaults to all characters.
- */
-
-string squeeze(string s, string pattern = null)