Changeset 1554

Timestamp:

05/26/10 05:59:01 (15 years ago)

Author:

rsinfu

Message:

Fixed bugzilla 3653: Problem sorting array of Rebindable.
Thanks to pc for the patch!

std.algorithm.sort does assignments over input array, but Rebindable did not have opAssign overload for Rebindable itself. This change implements Rebindable.opAssign(Rebindable).

Files:

• trunk/docsrc/changelog.dd (modified) (1 diff)
• trunk/phobos/std/typecons.d (modified) (2 diffs)

trunk/docsrc/changelog.dd

@@ -9 +9 @@
-    $(LI std.functional: toDelegate now accepts callable(function pointers, delegates and objects implement opCall) )
-    $(LI std.traits: Added templates to get compile-time information about functions.)
-    $(LI std.typecons: Added tie and AutoImplement.)
-    )
-    $(BUGSFIXED
-    $(LI $(BUGZILLA 2738): Rebindable should work for interfaces.)
-    $(LI $(BUGZILLA 2835): std.socket.TcpSocket doesn't actually connect)
-    $(LI $(BUGZILLA 3088): std.xml.check() fails on xml comments)
-    $(LI $(BUGZILLA 3200): std.xml doesn't follow spec for Tag.text)
-    $(LI $(BUGZILLA 3465): isIdeographic can be wrong in std.xml)
+    $(LI $(BUGZILLA 3653): Problem sorting array of Rebindable)
-    $(LI $(BUGZILLA 3873): std.range.repeat should have popBack defined)
-    $(LI $(BUGZILLA 3880): std.regex functions with const/immutable Regex object)
-    $(LI $(BUGZILLA 4109): writeln doesn't work with empty static array)
-    $(LI $(BUGZILLA 4202): Changset 1517 doesn't compile)
-    $(LI $(BUGZILLA 4228): std.array.replace contains 2 bugs)
-    $(LI $(BUGZILLA 4219): hasAliasing does not care about immutable)
-    )
-)
-
-<div id=version>

trunk/phobos/std/typecons.d

@@ -1015 +1015 @@
-        {
-            private union
-            {
-                T original;
-                U stripped;
-            }
-            void opAssign(T another)
-            {
-                stripped = cast(U) another;
-            }
+            void opAssign(Rebindable another)
+            {
+                stripped = another.stripped;
+            }
+            static if (is(T == const U))
+            {
+                // safely assign immutable to const
+                void opAssign(Rebindable!(immutable U) another)
+                {
+                    stripped = another.stripped;
+                }
+            }
-            static Rebindable opCall(T initializer)
-            {
-                Rebindable result;
-                result = initializer;
-                return result;
-            }
-            alias original get;
-            T opDot() {
-                return original;
-            }
@@ -1055 +1067 @@
-    static assert(is(typeof(obj2.stripped) == C));
-    obj2 = new immutable(C);
-    assert(obj1.get !is null);
-
-    // test opDot
-    assert(obj2.foo == 42);
-
-    interface I { final int foo() const { return 42; } }
-    Rebindable!(I) obj3;
-    static assert(is(typeof(obj3) == I));
-
+
+
+
+
+
+
+
+
+
+
+
+
+
-}
-
-/**
-  Order the provided members to minimize size while preserving alignment.
-  Returns a declaration to be mixed in.
-
-Example:
----
-struct Banner {
-  mixin(alignForSize!(byte[6], double)(["name", "height"]));