Ticket #10 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Message format in Loader

Reported by: keinfarbton Assigned to: keinfarbton
Priority: trivial Milestone: Pre-release 8
Component: Loader System Version: TRUNK
Keywords: Tango loader output Cc:

Description

Using tango, the app startup prints: 

Loaded lib = {}, libglade-2.0.so
Loaded lib = {}, libgtk-x11-2.0.so
Loaded lib = {}, libglib-2.0.so
Loaded lib = {}, libatk-1.0.so
Loaded lib = {}, libgobject-2.0.so
Loaded lib = {}, libgdk-x11-2.0.so
Loaded lib = {}, libgdk_pixbuf-2.0.so
Loaded lib = {}, libgthread-2.0.so
Loaded lib = {}, libpango-1.0.so

I found this places with grep 

gtkD/wrap/Loader.d:207: version(Tango) Stdout("Loaded lib = {}", libraryName).newline;
gtkD/src/gtkc/Loader.d:207: version(Tango) Stdout("Loaded lib = {}", libraryName).newline;

They should be corrected to: 

version(Tango) Stdout.formatln("Loaded lib = {}", libraryName);

Change History

12/28/07 13:56:00 changed by JJR

Thanks, Frank. :)

This is a wrapper related issue, I think... we'll have to make sure that this gets cleaned up as well.

In truth, it seems that we don't even need to use formatln. It's completely redundant in this line. Instead we can do 

version (Tango) Stdout ("Loaded lib = ", libraryName);
// or
version (Tango) Stdout ("Loaded lib = ") (libraryName);

or even a version using the much lighter Cout.

12/28/07 19:06:24 changed by Pse

  • keywords set to Tango loader output.
  • priority changed from major to trivial.
  • milestone set to Pre-release 8.

12/29/07 01:32:10 changed by Pse

  • version set to TRUNK.

12/29/07 21:30:43 changed by keinfarbton

I just realized, the message cannot be turned off. Would be cool if the application could disable this message. Or just remove it? In case of no problem, why print messages?

12/29/07 21:54:54 changed by JJR

Good point, Frank. I think it is purely diagnostic, a carry-over from early versions of gtkd. I agree that these messages should be disabled if no error. Thanks for the suggestion.

BTW, are you interested in being added as a developer here? Your reputation for D software development and bug-squashing is greatly respected :) (Tango, Tioport SWT, DBus-d, etc). Maybe you might find time to submit fixes now and again to GtkD or lend some ideas?

12/29/07 21:57:48 changed by JJR

  • status changed from new to assigned.

12/29/07 23:07:57 changed by keinfarbton

Would be nice to be a gtkd dev.
btw, is there a gtkd channel in irc?

12/29/07 23:58:27 changed by JJR

I've added you as a developer. :)

IRC was mentioned in another post. I think we should just go ahead and start one up. I'll give it a try and announce it in the forums.

12/31/07 01:32:55 changed by JJR

  • owner changed from JJR to keinfarbton.
  • status changed from assigned to new.

01/03/08 17:49:58 changed by Mike Wey

  • status changed from new to closed.
  • resolution set to fixed.

The output was fixed in r359.