Ticket #1 (closed task: fixed)

Opened 7 months ago

Last modified 7 months ago

Add aliases and overrides from generated file

Reported by: keinfarbton Assigned to: somebody
Priority: major Milestone:
Component: component1 Version:
Keywords: Cc:

Description

As attachment there is a file file containing all classes from the original SWT, which contain the aliases as they are needed in D and the methods that need the 'override' keyword.

It is needed to go through the sources and add the aliases at the top of the class and then search for all override methods and prepend the override keyword.

For modules, which only have a dummy type for porting and the original class is commented out, this shall be done in the commented class.

Attachments

win32-protos.txt (64.7 kB) - added by keinfarbton on 02/02/08 09:05:49.
generated prototypes
torhu.diff (61.0 kB) - added by torhu on 02/02/08 16:38:02.
work so far
torhu2.diff (207.6 kB) - added by torhu on 02/03/08 11:40:37.
the rest of it

Change History

02/02/08 09:05:49 changed by keinfarbton

  • attachment win32-protos.txt added.

generated prototypes

02/02/08 09:13:22 changed by keinfarbton

An example from the dwt-linux project how it should look like: Button.d Line 53

02/02/08 16:38:02 changed by torhu

  • attachment torhu.diff added.

work so far

02/02/08 16:39:53 changed by torhu

will continue tomorrow :)

02/03/08 11:40:37 changed by torhu

  • attachment torhu2.diff added.

the rest of it

02/03/08 11:42:17 changed by torhu

It's possible that I've done a couple of mistakes, like adding override to the wrong overload, etc. But you said you were going to verify it anyway. ;)

02/04/08 04:10:35 changed by keinfarbton

  • status changed from new to closed.
  • resolution set to fixed.

I don't expect problems. The compiler will check first and will show all misplaced overrides. Missing overrides cannot be detected, so later a verify is needed anyway. But its much easier when the overrides are in place for the most cases.

I committed the patches in revisions
9a64a7781bab
0f25be5cbe6f

Thanks torhu for doing this job.