Last Minute API review / changes

Two things I'm going to review:

• joystick: Lutger did an excellent job, I just want to fix some method names for consistency and support the pressed/released/up/down scheme for the buttons.
• sound: Is there ever a reason not to call process() in all created sounds and isn't the order of these calls unimportant? If it is, I think arc.sound should have a way to register sounds in a way that arc.sound.process() processes all these sounds. The registering could even be automatic if we're careful enough not to prohibit garbage collection with it.

What do you think about the sound thing?

I got rid of the font.drawMulti stuff.

Font now automatically assumes you want drawMulti all the time, and you just use

font.draw

instead.

About sound: I do not think order is important. It might be smart to register sounds and have registered sounds constantly processed, if the user desires. The only problem with it is a very slight performance decrease from processing a, for example, game menu sound when the game menu is not even opened.

I think it'll be handy and making things simpler. If the user desires, he can still call each process() seperately and avoid arc.sound.process(). About the performance penalty: I see that currently Sound.process() calls updateBuffers() regardless of it being stopped or not. Is it neccessary? - I have not gone through and understood the OpenAL workings.

Joystick adaptions are done with [1041].

The sound.process idea: It works, but requires the user to explicitly delete Sound classes in the destructor (which becomes legal, since there's a list of all Sound classes around and the gc can't collect them 'by accident').

Pro:

• arc.sound.process() calls all Sound.process() methods
• if you don't use arc.sound.process, everything stays the same

Con:

• if using arc.sound.process(), you need to explicitly delete Sound classes (or else might hear long or looping sounds continue to play)

What's your opinion?

An idea would be to make it more explicit:

class Some
{
  Sound sound;

  this() {
    sound = new Sound(...);
    sound.addToAutoProcessList(); // <- needs shorter method name, obviously ;)
  }

  ~this() { sound.removeFromAutoProcessList(); }
}

This way it'd be less confusing.

Explicitness is nice.

I don't have any real opinion on the issue as of now, as I haven't really digested the issue very much and nothing obvious is coming to mind.

The sound change was made with [1045]. I'm leaving the ticket open in case there's something left that you wanted to review.

Deprecated window.clear(). Not necessary anymore.

I'm not sure about deprecating window.clear and moving its functionality to swap... Now swap() doesn't only swap: it also clears!

I agree though that it's a valid thing to have, but the name is off. Maybe keep swap and clear (I think there may be uses for using one but not the other) and add a nextFrame() or something?

Maybe even swapAndClear()... ;)

added swapClear() and restored clear() and made swap only swap

I did some major function re-naming in the arc physics system using get/set instead of the property syntax.

I also added a 'setRadius' function for circle and a 'setSize' function for box shapes.

Hrm... this is probably done for v.2 release.