[davidl]

I've found when i place my binary in different directory would make the debugging system not functionating by setting the running working directory to somewhere else.(I already set my source directory to the source lookup directory, including looking up in subdirs option, )



And also if i F8 continue the execution to the func would make the local var not working. and sometimes, ddbg returns junk data , the console shows them, the speed is low.

[davidl]

Index: dtool/.classpath

===================================================================

--- dtool/.classpath (revision 633)

+++ dtool/.classpath (working copy)

@@ -3,7 +3,7 @@

<classpathentry kind="src" path="src-descent"/>

<classpathentry kind="src" path="src"/>

<classpathentry kind="src" path="src-util"/>

- <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/jdk1.6.0"/>

+ <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>

<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>

<classpathentry exported="true" kind="lib" path="libs/antlr-3.0b5.jar"/>

<classpathentry exported="true" kind="lib" path="libs/ini4j.jar" sourcepath="libs/ini4j-0.2.6/src/classes">

Index: descent.tests/descent/tests/launching/DmdCompilerType_Tests.class

===================================================================

Cannot display: file marked as a binary type.

svn:mime-type = application/octet-stream

Index: descent.debug.ui/src/descent/internal/debug/ui/model/DescentLineBreakpointAdapter.java

===================================================================

--- descent.debug.ui/src/descent/internal/debug/ui/model/DescentLineBreakpointAdapter.java (revision 633)

+++ descent.debug.ui/src/descent/internal/debug/ui/model/DescentLineBreakpointAdapter.java (working copy)

@@ -18,6 +18,8 @@

import descent.core.JavaCore;

import descent.debug.core.IDescentLaunchConfigurationConstants;

import descent.debug.core.model.DescentLineBreakpoint;

+import descent.core.dom.*;

+import descent.internal.compiler.parser.*;



public class DescentLineBreakpointAdapter implements IToggleBreakpointsTarget {



@@ -58,9 +60,26 @@

} catch (BadLocationException e) {

e.printStackTrace();

}

-

+ // FIXME: get document d version !!

+ AST ast = AST.newAST(AST.D1);

+ Parser parser = new Parser(ast, document.get());

+ Module mod = parser.parseModuleObj();

+ StringBuilder sb = new StringBuilder();

+ String modname;

+ if (mod.md != null){

+ for(IdentifierExp pack : mod.md.packages) {

+ sb.append(pack);

+ sb.append("/");

+ }

+ sb.append(mod.md.id);

+ modname = sb.toString();

+ modname = modname + ".d";

+ }

+ else

+ modname = resource.getLocation().lastSegment();

+

// create line breakpoint (doc line numbers start at 0)

- DescentLineBreakpoint lineBreakpoint = new DescentLineBreakpoint(resource, lineNumber + 1, charStart, charEnd);

+ DescentLineBreakpoint lineBreakpoint = new DescentLineBreakpoint(resource, modname, lineNumber + 1, charStart, charEnd);

DebugPlugin.getDefault().getBreakpointManager().addBreakpoint(lineBreakpoint);

}

}

Index: descent.ui/src/descent/internal/ui/wizards/JavaProjectWizardFirstPage.java

===================================================================

--- descent.ui/src/descent/internal/ui/wizards/JavaProjectWizardFirstPage.java (revision 633)

+++ descent.ui/src/descent/internal/ui/wizards/JavaProjectWizardFirstPage.java (working copy)

@@ -543,7 +543,7 @@

} else {
fHintText.setVisible(false);
}
- ?/
+ */
}

public void update(Observable o, Object arg) {
Index: descent.debug.core/src/descent/debug/core/model/DescentLineBreakpoint.java

===================================================================

--- descent.debug.core/src/descent/debug/core/model/DescentLineBreakpoint.java (revision 633)

+++ descent.debug.core/src/descent/debug/core/model/DescentLineBreakpoint.java (working copy)

@@ -10,18 +10,26 @@



import descent.debug.core.DescentDebugPlugin;

import descent.debug.core.IDescentLaunchConfigurationConstants;

+import descent.debug.core.IDescentLineBreakpoint;



-public class DescentLineBreakpoint extends LineBreakpoint {

+public class DescentLineBreakpoint extends LineBreakpoint implements IDescentLineBreakpoint{

+

+ String modulename;



+ public String getModuleName(){

+ return modulename;

+ }

+

public DescentLineBreakpoint() {

}



- public DescentLineBreakpoint(final IResource resource, final int lineNumber, final int charStart, final int charEnd) throws CoreException {

+ public DescentLineBreakpoint(final IResource resource,final String FileName, final int lineNumber, final int charStart, final int charEnd) throws CoreException {

IWorkspaceRunnable runnable = new IWorkspaceRunnable() {

public void run(IProgressMonitor monitor) throws CoreException {

IMarker marker = resource

.createMarker(DescentDebugPlugin.PLUGIN_ID + ".descentLineBreakpointMarker"); //$NON-NLS-1$

setMarker(marker);

+ modulename = FileName;

marker.setAttribute(IBreakpoint.ID, getModelIdentifier());

marker.setAttribute(IBreakpoint.ENABLED, Boolean.TRUE);

marker.setAttribute(IMarker.LINE_NUMBER, lineNumber);

Index: descent.debug.core/src/descent/internal/debug/core/model/DescentDebugTarget.java

===================================================================

--- descent.debug.core/src/descent/internal/debug/core/model/DescentDebugTarget.java (revision 633)

+++ descent.debug.core/src/descent/internal/debug/core/model/DescentDebugTarget.java (working copy)

@@ -25,6 +25,7 @@

import descent.debug.core.DescentDebugPlugin;

import descent.debug.core.IDescentLaunchConfigurationConstants;

import descent.debug.core.IDescentLaunchingPreferenceConstants;

+import descent.debug.core.IDescentLineBreakpoint;

import descent.debug.core.model.IDebugElementFactory;

import descent.debug.core.model.IDebugger;

import descent.debug.core.model.IDebuggerListener;

@@ -85,7 +86,7 @@

IBreakpoint[] breakpoints = manager.getBreakpoints(IDescentLaunchConfigurationConstants.ID_D_DEBUG_MODEL);

for(IBreakpoint breakpoint : breakpoints) {

if (breakpoint.isEnabled()) {

- fDebugger.addBreakpoint(breakpoint.getMarker().getResource().getLocation().toOSString(), ((ILineBreakpoint) breakpoint).getLineNumber());

+ fDebugger.addBreakpoint(((IDescentLineBreakpoint)breakpoint).getModuleName(), ((ILineBreakpoint) breakpoint).getLineNumber());

}

}

} catch (IOException e) {



this patch makes descent set breakpoint based on the AST parse result of module name to set breakpoint.
i use "/" to generate module path, this is supported by ddbg, so i think it's a nice way of getting both windows/linux(gdb) debugger happy
Though descent's debugging still get problem when i set a few breakpoints when i use F8 to continue those breakpoints, after a continuation, the editor seems fail to focus on correct source, ddbg returns correct source code and line, seems there lacks of some handling.

[davidl]

This patch fixes the problem as last patch, and also refreshes every breakpoint to a way that descent could understand.

[asterite]

Hi davidl.

We're planning on releasing a maintenance release which will have performance improvements, additions to the formatter as requested by the users, and possibly bug fixes. Could you update you svn copy and attach the patch to this ticket: http://www.dsource.org/projects/descent/ticket/21

Also, could you explain me what did you fix with the patch?

(sorry I didn't checked it before, I was more concerned with performance issues)

Thanks,
Ary